Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to add this module to an existing phoenix application, there is an unsolvable dependency issue:
The reason that "file_system" is locked to 1.0.0 is because "phoenix_live_reload" has a requirement of
{:file_system, "~> 0.2.10 or ~> 1.0"}
so 1.0.0 which was published Nov 09, 2023 is being installed.This PR simply updates the dep line from
{:file_system, "~> 0.2"}
to{:file_system, "~> 0.2 or ~> 1.0"}
so that it will work when added to old or new projects. The changes in "file_system" seem to be pretty minor, and the 1.0.0 was just since it has been stable for years and Jose Valim asked for it.I unlocked the dep so that tests would run, and also updated ex_doc's locked version so that the generated documentation is updated to the latest styles. I left junit_formatter alone since that's related to your CI.
Thanks for the lib!